Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tab list to scope map #3333

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Jan 9, 2024

This is to refactor the recoil states to use this new way.
I implemented it for the component TabList:

  • migrated scopedStates to stateScopeMaps
  • created a hook to load this states
  • refactored usage in the component and the parents to use this hooks

Tested through storybook and locally.

Copy link

github-actions bot commented Jan 9, 2024

CLA

Hello there and welcome to our project!
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.
Although we don't have a dedicated legal counsel, having this kind of agreement can protect us from potential legal issues or patent trolls.
Thank you for your understanding.

Generated by 🚫 dangerJS against 701bc85

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Left comments :)

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo!

@charlesBochet charlesBochet merged commit ebf7688 into main Jan 9, 2024
10 of 13 checks passed
@charlesBochet charlesBochet deleted the tt-migrate-tab-list-to-scope-map branch January 9, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants