Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for modules/object-record/hooks #3361

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Add tests for modules/object-record/hooks #3361

merged 3 commits into from
Jan 11, 2024

Conversation

gitstart-twenty
Copy link
Contributor

Fixes #3323

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>

const Wrapper = ({ children }: { children: ReactNode }) => (
<RecoilRoot>
<MockedProvider mocks={mocks} addTypename={false}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitstart-twenty does this fail if the request does not match the mock?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test ideally won't fail unless we're specifically asserting on the request or response data. However, Apollo will issue warnings if a request is made and not properly mocked.

@charlesBochet charlesBochet self-assigned this Jan 11, 2024
@charlesBochet charlesBochet merged commit 93a9eb0 into main Jan 11, 2024
13 checks passed
@charlesBochet charlesBochet deleted the TWNTY-3323 branch January 11, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for modules/object-record/hooks
2 participants