Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for modules/object-record/object-sort-dropdown #3366

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

gitstart-twenty
Copy link
Contributor

COVERAGE RESULTS

295685151-e916cea7-ebcf-4e09-a0cb-96fcf10fc8d0

Fixes #3325

Co-authored-by: RubensRafael <rubensrafael2@live.com>
@gitstart-twenty gitstart-twenty marked this pull request as ready for review January 11, 2024 10:18
@charlesBochet
Copy link
Member

@lucasbordeau @magrinj Do we want to name of test files .test or .spec to be consistent with the backend?

I prefer test personally as "spec" is less clear to me or for junior developers. The most important thing is to be consistent IMO

@charlesBochet
Copy link
Member

@lucasbordeau @magrinj Do we want to name of test files .test or .spec to be consistent with the backend?

I prefer test personally as "spec" is less clear to me or for junior developers. The most important thing is to be consistent IMO

It's not specific about this PR but I was thinking about it

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gitstart-twenty!

@charlesBochet charlesBochet merged commit 66a054a into main Jan 11, 2024
15 checks passed
@charlesBochet charlesBochet deleted the TWNTY-3325 branch January 11, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for modules/object-record/object-sort-dropdown
2 participants