Show page - disable click for workspace member relation #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
force-pushed
the
tt-disable-click-for-workspace-member-relations
branch
from
9aeaa09
to
454ae79
Compare
thomtrp
commented
Jan 15, 2024
| @@ -4,6 +4,54 @@ import { useRelationPicker } from '@/object-record/relation-picker/hooks/useRela | |||
| import { IdentifiersMapper } from '@/object-record/relation-picker/types/IdentifiersMapper'; | |||
| import { getLogoUrlFromDomainName } from '~/utils'; | |||
|
|
|||
| export const identifierMapper: IdentifiersMapper = ( | |||
There was a problem hiding this comment.
I did not modified the function. I just moved it out so I could export it in the test
thomtrp
force-pushed
the
tt-disable-click-for-workspace-member-relations
branch
from
3430dcc
to
db03b00
Compare
thomtrp
commented
Jan 16, 2024
| @@ -1,10 +1,17 @@ | |||
| import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem'; | |||
|
|
|||
| const isWorkspaceMember = (objectMetadataItem: ObjectMetadataItem) => | |||
| objectMetadataItem.nameSingular === 'workspaceMember'; | |||
There was a problem hiding this comment.
Should I build a type somewhere @charlesBochet @lucasbordeau?
thomtrp
force-pushed
the
tt-disable-click-for-workspace-member-relations
branch
from
db03b00
to
e94fb36
Compare
charlesBochet
deleted the
tt-disable-click-for-workspace-member-relations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling click for workspace member relation + adding a test on the component