replace text input by texterarea #3473
Conversation
|
Hi @jeet1desai! Thank you for your contribution! It's nearly perfect. Could you please make the box shadow expand along with the input? Also, can you add an overflow when the input is closed to prevent its content from overflowing on the right? |
|
Hi, here are some technical guidelines :
|
overflow.and.replace.text.webm |
…ace-text-input-by-texterarea
| @@ -82,7 +82,7 @@ export const LinkFieldInput = ({ | |||
|
|
|||
| return ( | |||
| <FieldInputOverlay> | |||
| <TextInput | |||
| <TextArea | |||
There was a problem hiding this comment.
let's leave the text input for links for now
| } | ||
| `; | ||
|
|
||
| export const TextArea = ({ |
There was a problem hiding this comment.
I would name it TextAreaInput to be consistent with others
Could you also add storybook story on top of it?
There was a problem hiding this comment.
Hello @charlesBochet, I wanted to check with you regarding the creation of the storybook story for this specific file.
It seems that this component is utilized in the TextFieldInput.tsx file, and this file has already been incorporated into the storybook.
Could you confirm if you would like the storybook story to be crafted exclusively for this particular file?
Thank you.
There was a problem hiding this comment.
ok, I feel we should cover the UI folder but this can wait a bit, LGTM
| @@ -5,7 +5,6 @@ import { ThemeType } from './theme'; | |||
| export const overlayBackground = (props: { theme: ThemeType }) => css` | |||
| backdrop-filter: blur(8px); | |||
| background: ${props.theme.background.transparent.secondary}; | |||
| box-shadow: ${props.theme.boxShadow.strong}; | |||
There was a problem hiding this comment.
why are we removing this?
| border-radius: ${({ theme }) => theme.border.radius.sm}; | ||
| box-sizing: border-box; | ||
| color: ${({ theme }) => theme.font.color.primary}; | ||
| font-family: inherit; |
There was a problem hiding this comment.
are all these css properties useful?
font-family inherit?
| @@ -56,7 +56,7 @@ export const EmailFieldInput = ({ | |||
|
|
|||
| return ( | |||
| <FieldInputOverlay> | |||
| <TextInput | |||
| <TextArea | |||
There was a problem hiding this comment.
let's keep email field as TextInput, multi line is not useful there
…ace-text-input-by-texterarea
|
Hello @charlesBochet, All the comment is resolved now, can you please check and let me know if there is anything you want to change. Thank you. |
Fixes #3472
replace.text.input.webm