Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display label identifier table cell as chip with link to Record… #3503

Merged
merged 3 commits into from
Jan 17, 2024
Merged

feat: display label identifier table cell as chip with link to Record… #3503

merged 3 commits into from
Jan 17, 2024

Conversation

thaisguigon
Copy link
Contributor

…ShowPage

Closes #3502

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited

TODOs/FIXMEs:

  • // TODO: remove this and use ObjectRecordChip instead: packages/twenty-front/src/modules/object-record/field/meta-types/display/components/ChipFieldDisplay.tsx

Generated by 🚫 dangerJS against ca870bc

@thaisguigon thaisguigon marked this pull request as ready for review January 17, 2024 10:16
@thaisguigon thaisguigon force-pushed the feat/label-identifier-chip-cell branch from 675a721 to f757245 Compare January 17, 2024 12:55
charlesBochet
charlesBochet approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say, glad we got rid of these Identifiers Mapper

@charlesBochet charlesBochet merged commit 2d929c3 into main Jan 17, 2024
12 of 13 checks passed
@charlesBochet charlesBochet deleted the feat/label-identifier-chip-cell branch January 17, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RecordTables - Display Record identifier field as chip cell with link to RecordShowPage
2 participants
@thaisguigon @charlesBochet