Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken calendar component #3525

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Broken calendar component #3525

merged 6 commits into from
Jan 23, 2024

Conversation

jeet1desai
Copy link
Contributor

Fix: #3520

image

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeet1desai This should already be applied in MultipleFiltersDropdownFilterOnFilterChangedEffect could you take a look.
I believe it is because the dropdownId do not match: viewFilter.fieldMetadataId vs ObjectFilterDropdownId

@jeet1desai
Copy link
Contributor Author

Hey @charlesBochet,

I've looked into the issue with the MultipleFiltersDropdownFilterOnFilterChangedEffect. It appears that the dropdownId is successfully matched, and the effect is updating the width as expected. However, despite the width being updated, it doesn't seem to be applied to the dropdown.

Any insights or suggestions you have on this matter would be greatly appreciated.

Thank you.

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeet1desai I've made another fix.
I'm removing this hard coded ObjectFilterDropdownId.

This means that useDropdown will take the dropdown "componentId" that has been set above in the component hierachy (viewFilter.fieldMetadataId if we click on on the FilterChip, ObjectFilterDropdownId if we click on the "Filter" button)

Here we were trying to always modify the dropdownWidth of the dropdown which dropdownId was ObjectFilterDropdownId (which is the dropdown when you click on 'Filter' but not when you click on the FilterChip in the View detail bar)

@charlesBochet charlesBochet merged commit c9e326f into twentyhq:main Jan 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken calendar component on filter
2 participants