-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken calendar component #3525
Broken calendar component #3525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeet1desai This should already be applied in MultipleFiltersDropdownFilterOnFilterChangedEffect could you take a look.
I believe it is because the dropdownId do not match: viewFilter.fieldMetadataId vs ObjectFilterDropdownId
Hey @charlesBochet, I've looked into the issue with the MultipleFiltersDropdownFilterOnFilterChangedEffect. It appears that the dropdownId is successfully matched, and the effect is updating the width as expected. However, despite the width being updated, it doesn't seem to be applied to the dropdown. Any insights or suggestions you have on this matter would be greatly appreciated. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeet1desai I've made another fix.
I'm removing this hard coded ObjectFilterDropdownId.
This means that useDropdown will take the dropdown "componentId" that has been set above in the component hierachy (viewFilter.fieldMetadataId if we click on on the FilterChip, ObjectFilterDropdownId if we click on the "Filter" button)
Here we were trying to always modify the dropdownWidth of the dropdown which dropdownId was ObjectFilterDropdownId (which is the dropdown when you click on 'Filter' but not when you click on the FilterChip in the View detail bar)
Fix: #3520