Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip on icons #3529

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Tooltip on icons #3529

merged 6 commits into from
Jan 23, 2024

Conversation

seAfnan
Copy link
Contributor

@seAfnan seAfnan commented Jan 18, 2024

I have used label as a tooltip on hover icons
twenty-hover-icon

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seAfnan Thank you for the PR, I've left a comment!

@seAfnan
Copy link
Contributor Author

seAfnan commented Jan 18, 2024

@seAfnan Thank you for the PR, I've left a comment!

Now see the changes

@FelixMalfait
Copy link
Member

Thanks @seAfnan!

@Bonapara do we want to show a tooltip if we show labels? For me it was an IF

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I've tried it and figured out that we don't want any space in the html id attribute (therefore using kebabcase). Also, I'm not displaying the tooltipe if we show labels

@charlesBochet charlesBochet merged commit 0100244 into twentyhq:main Jan 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants