-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: apply record optimistic effects with cache.modify on mutation #3540
Merged
lucasbordeau
merged 12 commits into
main
from
perf/apply-optimistic-effects-on-mutation
Jan 23, 2024
Merged
perf: apply record optimistic effects with cache.modify on mutation #3540
lucasbordeau
merged 12 commits into
main
from
perf/apply-optimistic-effects-on-mutation
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaisguigon
force-pushed
the
perf/apply-optimistic-effects-on-mutation
branch
from
January 19, 2024 15:33
e636470
to
79bcf60
Compare
packages/twenty-front/src/modules/apollo/optimistic-effect/utils/isCachedObjectConnection.ts
Show resolved
Hide resolved
...ject-record/relation-picker/hooks/useMultiObjectSearchMatchesSearchFilterAndToSelectQuery.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/developers/api-keys/SettingsDevelopersApiKeyDetail.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/apollo/optimistic-effect/utils/sortCachedObjectEdges.ts
Outdated
Show resolved
Hide resolved
...nty-front/src/modules/apollo/optimistic-effect/utils/triggerCreateRecordsOptimisticEffect.ts
Show resolved
Hide resolved
...nty-front/src/modules/apollo/optimistic-effect/utils/triggerDeleteRecordsOptimisticEffect.ts
Show resolved
Hide resolved
...enty-front/src/modules/apollo/optimistic-effect/utils/triggerUpdateRecordOptimisticEffect.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/hooks/useGenerateCreateManyRecordMutation.ts
Show resolved
Hide resolved
...ont/src/modules/object-record/record-filter/utils/turnObjectDropdownFilterIntoQueryFilter.ts
Outdated
Show resolved
Hide resolved
…dOptimisticEffect
…ultiObjectSearchMatchesSearchFilterAndToSelectQuery
thaisguigon
force-pushed
the
perf/apply-optimistic-effects-on-mutation
branch
from
January 23, 2024 14:45
8564e2a
to
9025979
Compare
thaisguigon
force-pushed
the
perf/apply-optimistic-effects-on-mutation
branch
from
January 23, 2024 15:42
9025979
to
b4f68c1
Compare
lucasbordeau
approved these changes
Jan 23, 2024
packages/twenty-front/src/modules/apollo/optimistic-effect/utils/sortCachedObjectEdges.ts
Show resolved
Hide resolved
...record/relation-picker/hooks/useMultiObjectSearchMatchesSearchFilterAndSelectedItemsQuery.ts
Show resolved
Hide resolved
Nice work ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3509