-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rate limiting in the server using built in Nest.js capability #3566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution !
Some changes and tests are needed before merging it 🙂
packages/twenty-server/src/integrations/environment/environment.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/integrations/environment/environment.service.ts
Outdated
Show resolved
Hide resolved
571e6a4
to
08cdfaa
Compare
c714efc
to
95700a9
Compare
@jss475 Thanks for your work, I've change the code because our graphQL schema is dynamically constructed, so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments. We should also add the environment variables to the documentation
packages/twenty-server/.env.example
Outdated
@@ -52,3 +52,5 @@ SIGN_IN_PREFILLED=true | |||
# EMAIL_SMTP_USER= | |||
# EMAIL_SMTP_PASSWORD= | |||
# PASSWORD_RESET_TOKEN_EXPIRES_IN=5m | |||
# LOGGED_IN_LONG_TTL= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this naming, reading the code to understand what it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API_RATE_LIMITING_TTL
API_RATE_LIMITING_LIMIT
#3545