-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added webhook list section and updated api key section #3567
Merged
martmull
merged 7 commits into
twentyhq:main
from
lakshay-saini-au8:feat/add-webhook-list-section
Jan 25, 2024
Merged
feat: added webhook list section and updated api key section #3567
martmull
merged 7 commits into
twentyhq:main
from
lakshay-saini-au8:feat/add-webhook-list-section
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martmull
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lakshay-saini-au8 thank you very much for this PR. It is really good work. Left some comments
packages/twenty-front/src/pages/settings/developers/SettingsDevelopersWebhooks.tsx
Outdated
Show resolved
Hide resolved
...wenty-front/src/modules/settings/developers/components/SettingsDevelopersWebhookTableRow.tsx
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/developers/SettingsDevelopersApiKeys.tsx
Show resolved
Hide resolved
...wenty-front/src/modules/settings/developers/components/SettingsDevelopersWebhookTableRow.tsx
Outdated
Show resolved
Hide resolved
Hey @lakshay-saini-au8, I will pass the changes on that feature to merge it quickly. Thank you for your work, it was great job! Have a nice day |
lucasbordeau
requested changes
Jan 25, 2024
packages/twenty-front/src/pages/settings/developers/SettingsDevelopersWebhooks.tsx
Outdated
Show resolved
Hide resolved
lucasbordeau
approved these changes
Jan 25, 2024
martmull
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Webhook List section and updated the UI for api key section
#3271