Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build message thread empty right drawer #3585

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Jan 22, 2024

Clicking on an email should open a right drawer. This PR:

  • refactor a bit the right drawer for activities to re-use some components
  • create a right drawer for message thread
  • triggers it using the same logic as for activities, by clicking the thread preview
Capture d’écran 2024-01-22 à 18 38 45

@thomtrp thomtrp force-pushed the tt-build-empty-thread-component branch from 1c671a7 to cf39d28 Compare January 22, 2024 17:35
<StyledThreadCount>{thread.numberOfMessagesInThread}</StyledThreadCount>
</StyledHeading>
export const ThreadPreview = ({ divider, thread }: ThreadPreviewProps) => {
const openMessageThreadRightDrawer = useOpenMessageThreadRightDrawer();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only added the line above and the onClick in the style card content

import React from 'react';
import styled from '@emotion/styled';

const StyledContainer = styled.div`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may set this style generic in another PR

@thomtrp thomtrp force-pushed the tt-build-empty-thread-component branch from cf39d28 to e9a3d8f Compare January 22, 2024 17:48
@thomtrp thomtrp marked this pull request as ready for review January 22, 2024 17:49
@bosiraphael bosiraphael self-requested a review January 23, 2024 09:26
@bosiraphael
Copy link
Contributor

Add a component folder inside packages/twenty-front/src/modules/activities/emails/right-drawer

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@bosiraphael bosiraphael merged commit 004c237 into main Jan 23, 2024
13 checks passed
@bosiraphael bosiraphael deleted the tt-build-empty-thread-component branch January 23, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants