Fix Continuous Deployment script after adding twenty-emails package #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martmull
approved these changes
Jan 23, 2024
charlesBochet
commented
Jan 23, 2024
| @@ -11,11 +11,15 @@ COPY ./yarn.lock . | |||
| COPY ./.yarnrc.yml . | |||
| COPY ./.yarn/releases /app/.yarn/releases | |||
| COPY ./tools/eslint-rules /app/tools/eslint-rules | |||
| COPY ./packages/twenty-front /app/packages/twenty-front | |||
| COPY ./packages/twenty-emails /app/packages/twenty-emails | |||
| COPY ./packages/twenty-front/package.json /app/packages/twenty-front/package.json | |||
There was a problem hiding this comment.
we only copy package.json at this stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adding twenty-emails dependencies to its own package.json to enable build without pulling all repo dependencies
Adding twenty-emails build to twenty-server Dockerfile
Adding twenty-emails to twenty-front and twenty-docs (as we still install all dependencies for front and emails until we take a final decision on nx)
Optimizing slightly twenty-front Dockerfile to not re-install node modules if package.json hasn't change