Build message threads #3593
Merged
Build message threads #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
force-pushed
the
tt-build-message-threads
branch
from
c10516f
to
cf081ee
Compare
thomtrp
force-pushed
the
tt-build-message-threads
branch
from
cf081ee
to
986b0dc
Compare
thomtrp
commented
Jan 24, 2024
| } else { | ||
| setIsOpenedMessage(id); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Should I build a hook useThreadMessage ? Or is it acceptable to keep that logic in the component?
thomtrp
force-pushed
the
tt-build-message-threads
branch
from
986b0dc
to
dd68e85
Compare
thomtrp
force-pushed
the
tt-build-message-threads
branch
from
dd68e85
to
258c269
Compare
packages/twenty-front/src/modules/activities/emails/components/MessageThread.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/activities/emails/components/MessageThread.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/activities/emails/components/MessageThread.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/activities/emails/components/MessageThread.tsx
Outdated
Show resolved
Hide resolved
...ges/twenty-front/src/modules/activities/emails/right-drawer/components/RightDrawerThread.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| import { MockedThread } from '@/activities/emails/mocks/mockedThreads'; | ||
|
|
||
| export const viewableThreadState = atom<MockedThread | null>({ |
There was a problem hiding this comment.
I'm very surprise about the typing getting out of the mocks!
There was a problem hiding this comment.
Also, I think this state is not useful, we should rely on apollo and not on the cache.
There was a problem hiding this comment.
Agreed. But I will test it once I do not have to mock the data anymore. For now I am not performing any query
There was a problem hiding this comment.
About the typing, this is something you want to discuss with Coco and Raphael to redefine the API?
charlesBochet
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logic to fill the right drawer with all messages:
In future PRs:
Enregistrement.de.l.ecran.2024-01-24.a.10.56.42.mov