Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load empty board if view type is kanban #3605

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Load empty board if view type is kanban #3605

merged 3 commits into from
Jan 24, 2024

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Jan 24, 2024 •
edited

Context

We are refactoring the record board which has been hard coded in the codebase to display opportunities.

What

In this PR:

  • I'm introducing a RecordIndexContainer which will conditionally load RecordIndexTableContainer or RecordIndexBoardContainer depending on viewType
  • I'm removing viewType as part of viewBar state as we don't need it (the data is already stored in apollo)
  • I'm adding onViewTypeChange as part of viewBar api to enable listening to viewType update
  • I'm loading all views in the viewBar (both table and kanban)

Next step:

Display a basic board UI

Weiko
Weiko approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesBochet charlesBochet merged commit ccbf773 into main Jan 24, 2024
13 checks passed
@charlesBochet charlesBochet deleted the load-board-if-view-type-is-kanban branch January 24, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weiko Weiko Weiko approved these changes

Assignees
No one assigned
Labels
run-chromatic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charlesBochet @Weiko