-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3263 modify timeline messagingservice to allow the frontend to get multiple participants in a thread #3611
Conversation
…ow-the-frontend-to-get-multiple-participants-in-a-thread
@@ -88,24 +88,22 @@ export const EmailThreadPreview = ({ | |||
thread, | |||
onClick, | |||
}: EmailThreadPreviewProps) => { | |||
const displayName = | |||
thread.firstParticipant.firstName || thread.firstParticipant.handle; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use displayName before handle?
const timelineThreads = mockedEmailThreads; | ||
const timelineThreads: TimelineThread[] = | ||
threads.data[ | ||
entity.targetObjectNameSingular === 'person' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use CoreObjectNameSingular
|
||
import { JwtAuthGuard } from 'src/guards/jwt.auth.guard'; | ||
import { Workspace } from 'src/core/workspace/workspace.entity'; | ||
import { AuthWorkspace } from 'src/decorators/auth-workspace.decorator'; | ||
import { TimelineMessagingService } from 'src/core/messaging/timeline-messaging.service'; | ||
|
||
@Entity({ name: 'timelineThreadParticipant', schema: 'core' }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want this line since this is not a typeorm entity
packages/twenty-server/src/core/messaging/timeline-messaging.resolver.ts
Show resolved
Hide resolved
…ow-the-frontend-to-get-multiple-participants-in-a-thread
packages/twenty-front/src/modules/activities/emails/mocks/mockedEmailThreads.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/activities/emails/queries/getTimelineThreadsFromCompanyId.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/core/messaging/timeline-messaging.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/core/messaging/timeline-thread-participant.dto.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/core/messaging/timeline-thread.dto.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/core/messaging/timeline-thread.dto.ts
Outdated
Show resolved
Hide resolved
…ow-the-frontend-to-get-multiple-participants-in-a-thread
packages/twenty-front/src/modules/activities/emails/components/EmailThreads.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/core/messaging/timeline-messaging.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job @bosiraphael 👏
Closes #3263