Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch messages with hard coded thread id #3613

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Jan 25, 2024

Calling backend to fetch messages:

  • retrieve thread id from state
  • adding a findManyRecords query in right drawer email container
  • adding new object record types based on the backend response
  • adapt props based on these types

Remaining work:

  • call backend to retrieve threads. This is the last part mocked
  • see if we need to store the viewable thread in state or if we can use apollo cache
  • add pagination + infinite scroll for both threads and thread messages
  • display recipients in design + do a pass on design in general

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment to address before merging!


const displayName = getDisplayNameFromParticipant(from);

const avatarUrl =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Do we handle auto-generated avatar using the displayName if avatarUrl is absent in EmailThreadMessageSender?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! An empty string (which is the default value) will generate an avatar with the first letter of the display name

@thomtrp thomtrp merged commit 7845e04 into main Jan 25, 2024
13 checks passed
@thomtrp thomtrp deleted the tt-fetch-thread-messages branch January 25, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants