[Messaging] Fix duplicate messageChannelMessage #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weiko
changed the title
| return; | ||
| } | ||
|
|
||
| const existingMessageChannelMessages = |
There was a problem hiding this comment.
messageChannelMessageAssociations
charlesBochet
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check before inserting anything if a messageChannelMessage already exists. This should not happen however this part of the code is executed in a job so we want to make sure this part is idempotent in case of retry strategies.
It also adds a check in the partial-sync import, where we don't want to import messages that are in both messageAdded and messageDeleted. This can happen when we do a partial sync after a message has been created (DRAFT or SENT) then deleted, since querying later on with gmail api will result in a 404.