Display columns on Record Board #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
changed the title
Weiko
reviewed
Jan 25, 2024
| return ( | ||
| <RecordBoardScope | ||
| recordBoardScopeId={recordBoardId} | ||
| recordBoardScopeId={getScopeIdFromComponentIdStrict(recordBoardId)} |
There was a problem hiding this comment.
Why strict here? I feel like strict does not really tell what you want?
| const setRecordBoardColumns = useRecoilCallback( | ||
| ({ set, snapshot }) => | ||
| (columns: RecordBoardColumnDefinition[]) => { | ||
| const currentColumns = snapshot |
There was a problem hiding this comment.
Suggested change
| const currentColumns = snapshot | |
| const currentColumnIds = snapshot |
...enty-front/src/modules/object-record/record-board/hooks/internal/useSetRecordBoardColumns.ts
Show resolved
Hide resolved
thomtrp
approved these changes
Jan 25, 2024
| columnDefinition: BoardColumnDefinition; | ||
| columnDefinition: RecordBoardColumnDefinition; | ||
| isColumnFirst: boolean; | ||
| isColumnLast: boolean; |
There was a problem hiding this comment.
I would have name is isFirst/LastColumn
| @@ -0,0 +1,7 @@ | |||
| import { createFamilyStateScopeMap } from '@/ui/utilities/recoil-scope/utils/createFamilyStateScopeMap'; | |||
|
|
|||
| export const isRecordBoardColumnFirstFamilyStateScopeMap = | |||
There was a problem hiding this comment.
I would also change this naming
| const navigate = useNavigate(); | ||
|
|
||
| const navigateToSelectSettings = useCallback(() => { | ||
| navigate(`/settings/objects/${objectNamePlural}`); |
Weiko
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are refactoring the record board which has been hard coded in the codebase to display opportunities.
What
In this PR:
Next steps: