Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch graphql errors #3634

Conversation

bosiraphael
Copy link
Contributor

Closes #3627

@@ -74,7 +83,9 @@ export const EmailThreads = ({
title={
<>
Inbox{' '}
<StyledEmailCount>{timelineThreads?.length}</StyledEmailCount>
<StyledEmailCount>
{timelineThreads?.length ?? 0}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather set an empty array in timelineThreads if undefined line 73. This way you do not need this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

@bosiraphael bosiraphael merged commit 49b22ee into main Jan 26, 2024
13 checks passed
@bosiraphael bosiraphael deleted the 3627-add-error-handling-in-packagestwenty-frontsrcmodulesactivitiesemailscomponentsemailthreadstsx branch January 26, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error handling in packages/twenty-front/src/modules/activities/emails/components/EmailThreads.tsx
2 participants