Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Opportunities page #3660

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Fix Opportunities page #3660

merged 3 commits into from
Jan 28, 2024

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Jan 28, 2024 •
edited

In this PR:

  • fixing broken active highlight of MetadataItem nav link
  • fixing missing cell border on RecordTable (lost in the previous PR)
  • removing opportunity recordIdentifier edge case
  • using RecordChip on ShowPage > Relation instead of a field

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2024 •
edited

TODOs/FIXMEs:

  • // TODO: temporary as ChipDisplay expect to find the entity in the entityFieldsFamilyState: packages/twenty-front/src/modules/object-record/record-relation-card/components/RecordRelationFieldCardContent.tsx

Generated by 🚫 dangerJS against 2ac7df3

@charlesBochet charlesBochet merged commit 6eca6dc into main Jan 28, 2024
13 checks passed
@charlesBochet charlesBochet deleted the fix-opportunities-page branch January 28, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@charlesBochet