fix: options value can't contain special characters #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,8 +5,19 @@ import { Field } from '~/generated-metadata/graphql'; | |||
|
|
|||
| import { FieldMetadataOption } from '../types/FieldMetadataOption'; | |||
|
|
|||
| const getOptionValueFromLabel = (label: string) => | |||
| toSnakeCase(label.trim()).toUpperCase(); | |||
| const getOptionValueFromLabel = (label: string) => { | |||
There was a problem hiding this comment.
it would be great to add tests on this function
There was a problem hiding this comment.
@charlesBochet I've added some tests, let me know if it's what you had in mind and if we can merge
There was a problem hiding this comment.
@Weiko Thanks for the tests, I've just added an emoji test
magrinj
force-pushed
the
fix/options-value
branch
from
42291bc
to
79d1beb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we put special characters like emoji inside options, the value generated by the front-end should strip the special characters and accents.
Fix #3296