Custom object import csv

[brendanlaschke]

Adds the csv import for all objects.

closes #3247

[FelixMalfait]

I don't think you missed anything important, this is the same direction I had in mind!

One challenge will be to handle creating relationships by passing an Id but we can do that in another issue/PR!
(Often people that are migrating have an existing list of people/companies so the workflow would probably be (1) import companies in Twenty (2) Export companies from Twenty to get the ID (3) attach the ID in my google sheet list of people with a vlookup (4) Import people)

[brendanlaschke]

I don't think you missed anything important, this is the same direction I had in mind!

One challenge will be to handle creating relationships by passing an Id but we can do that in another issue/PR! (Often people that are migrating have an existing list of people/companies so the workflow would probably be (1) import companies in Twenty (2) Export companies from Twenty to get the ID (3) attach the ID in my google sheet list of people with a vlookup (4) Import people)

I think this shouldn't be a problem ... Do we validate these relation ids before the graphql insert ?

[brendanlaschke]

Im a bit confused figuring out the problem with the test - shouldn't the mocked response be matched? They seem to be the same ?

 Expected variables: 
{"data":[{"address":<undefined>,"annualRecurringRevenue":{"amountMicros":null,"currencyCode":"USD"},"domainName":"example.com","employees":null,"idealCustomerProfile":true,"linkedinLink":{"label":"linkedinLink","url":null},"name":"Example Company","xLink":{"label":"xLink","url":null},"id":"cb2e9f4b-20c3-4759-9315-4ffeecfaf71a"}]}
    
    Failed to match 1 mock for this query. The mocked response had the following variables:
{"data":[{"address":<undefined>,"annualRecurringRevenue":{"amountMicros":null,"currencyCode":"USD"},"domainName":"example.com","employees":null,"idealCustomerProfile":true,"linkedinLink":{"label":"linkedinLink","url":null},"name":"Example Company","xLink":{"label":"xLink","url":null},"id":"cb2e9f4b-20c3-4759-9315-4ffeecfaf71a"}]}
    
    This typically indicates a configuration error in your mocks setup, usually due to a typo or mismatched variable.

[FelixMalfait]

Im a bit confused figuring out the problem with the test - shouldn't the mocked response be matched? They seem to be the same ?

Mmh I don't see the issue either! The only thing is with "address":<undefined>, maybe <undefined> != <undefined>?

I think this shouldn't be a problem ... Do we validate these relation ids before the graphql insert ?
Great!

We have foreign keys in DB so it will fail at that layer probably... (unless pg_graphql catches it before but I doubt it). It will force us to improve that kind of error handling, same problem with the API anyone can use already

[brendanlaschke]

Apparently it was the undefined - thanks :)

[FelixMalfait]

Great! I tested it and it works well!
Small feedbacks:

1. non-blocking error

2. for composite field would probably be best to be consistent with other field types and not send them at all if they're empty

3. I agree with "TODO validate Relation Ids?", I don't think we should do a check on the object itself (server) but we could at least validate it's in a uuid format?

4. We should only show the relationship where we have a foreign key on the target import table. So for example on the person table we should have companyId, but we should not have Attachments, Activities, Favorites... Because an activity belongsTo a company and we only want to import the object a company has in my opinion

[brendanlaschke]

Should be fixed!

[FelixMalfait]

Perfect! Tested again and it works (including creating the relationship)
Thanks a lot!!!

[brendanlaschke]

@quest-bot loot #3247

[quest-bot]

Quest PR submitted!

@brendanlaschke You are attempting to solve the issue and loot this Quest. Will you be successful?

---

Questions? Check out the docs.

[quest-bot]

🧚 @brendanlaschke congratulations for completing Quest #3247

💰 A reward of $250 has been credited to you.

To claim your $250 reward follow the instructions here.

Questions? Check out the docs.