Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored dependencies from App component #3763

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

lucasbordeau
Copy link
Contributor

  • Refactored app title from location to DefaultPageTitle to remove dependency from App component
  • Refactored DefaultHomePage to remove dependency to objectMetadataItems from App component

@lucasbordeau lucasbordeau changed the title Refactor/app title Remove dependencies from App component Feb 1, 2024
@lucasbordeau lucasbordeau changed the title Remove dependencies from App component Removed dependencies from App component Feb 1, 2024
@lucasbordeau lucasbordeau changed the title Removed dependencies from App component Refactored dependencies from App component Feb 2, 2024
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasbordeau lucasbordeau merged commit 33bb48e into main Feb 5, 2024
13 checks passed
@lucasbordeau lucasbordeau deleted the refactor/app-title branch February 5, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants