GH-3652 Add forgot password on sign-in page #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
requested changes
Feb 4, 2024
There was a problem hiding this comment.
Thank you @i-am-chitti, looks good from a high level code perspective. I have added comments.
packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpForm.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpForm.tsx
Outdated
Show resolved
Hide resolved
|
Hi @i-am-chitti! Any update on this one? :) |
|
Sorry @charlesBochet, I didn't get to work on this past days. I'll work on this today. |
|
@charlesBochet Please check the PR feedback comments for new reply. |
|
@martmull could you do the split? :) |
|
@i-am-chitti @charlesBochet I will |
martmull
force-pushed
the
GH-3652/forgot-password-sign-in-page
branch
from
ff799f8
to
c056498
Compare
charlesBochet
approved these changes
Feb 9, 2024
|
Hey @i-am-chitti this is merged. Thank you very much for your contribution it is really good work. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a forgot your password button on sign-in page.
Issue
Screenshots
Technical choices
Note
graphql.tsxis containing some irrelevant changes. Not sure, how they are popping into though had tried with merging latest main branch at the moment. Feel free to push to update the generated graphql at your will.