Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deletion support on sync metadata command #3826

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

magrinj
Copy link
Member

@magrinj magrinj commented Feb 5, 2024

In this PR we're adding deletion support for workspace:sync-metadata command, and fixing issue with RELATION field trying to be deleted.

@magrinj magrinj marked this pull request as ready for review February 5, 2024 17:05
@charlesBochet charlesBochet self-assigned this Feb 6, 2024
@magrinj magrinj force-pushed the feat/sync-metadata-delete-relation branch from 56b22a7 to a7f4877 Compare February 6, 2024 15:14
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magrinj magrinj merged commit a908353 into main Feb 7, 2024
12 of 13 checks passed
@magrinj magrinj deleted the feat/sync-metadata-delete-relation branch February 7, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants