Store compact view status #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
commented
Feb 6, 2024
| @@ -33,6 +34,15 @@ export const RecordIndexBoardContainerEffect = ({ | |||
| getOnFetchMoreVisibilityChangeState, | |||
| } = useRecordBoard(recordBoardId); | |||
|
|
|||
| const { currentViewSelector } = useViewScopedStates({ | |||
| viewScopeId: viewBarId, | |||
There was a problem hiding this comment.
this is used that way in other places in the code. Should I do a refacto?
There was a problem hiding this comment.
No, we'll take care of that while refactoring the ViewBar later this month
Weiko
reviewed
Feb 7, 2024
| description: 'Describes if the view is in compact mode', | ||
| defaultValue: { value: false }, | ||
| }) | ||
| isCompactView: boolean; |
charlesBochet
approved these changes
Feb 8, 2024
| @@ -33,6 +34,15 @@ export const RecordIndexBoardContainerEffect = ({ | |||
| getOnFetchMoreVisibilityChangeState, | |||
| } = useRecordBoard(recordBoardId); | |||
|
|
|||
| const { currentViewSelector } = useViewScopedStates({ | |||
| viewScopeId: viewBarId, | |||
There was a problem hiding this comment.
No, we'll take care of that while refactoring the ViewBar later this month
| } | ||
| // We don't want to re-run this effect when the state changes. | ||
| // We only want to make sure that the state reflects the current view. | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
We should not try to block react re-rendering. It's an effect, it is not a problem :)
charlesBochet
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, compact view status is only set in the state. This is not stored in DB so it gets reset when the page is refreshed.
This PR stores it as a boolean in the view.
Enregistrement.de.l.ecran.2024-02-06.a.16.24.41.mov