Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3865-Add-Integrations #3870

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Conversation

Kanav-Arora
Copy link
Contributor

@Kanav-Arora Kanav-Arora commented Feb 7, 2024

Closes #3865

I have coded constant in such a way that in future new integrations can be easily added.

Screenshot 2024-02-08 at 11 37 42 AM

@Kanav-Arora Kanav-Arora changed the title 3865-Add-Integrations WIP: 3865-Add-Integrations Feb 7, 2024
@Kanav-Arora Kanav-Arora marked this pull request as ready for review February 7, 2024 15:08
@Kanav-Arora
Copy link
Contributor Author

Kanav-Arora commented Feb 7, 2024

@FelixMalfait I'm done with the design. I have coded constant in such a way that in future new integrations can be easily added. I have two doubts:

@FelixMalfait
Copy link
Member

That's great as always @Kanav-Arora thanks!
Sorry if it wasn't clear, on the initial issue I added:

(as you can see I updated the text - but don't have edit rights to the original Figma)

What I meant was that the examples I think we should have were the one I added in my screenshot (cal.com, Slack, Mailchimp, Tally)

@Kanav-Arora
Copy link
Contributor Author

Kanav-Arora commented Feb 7, 2024

@FelixMalfait Sorry now I get it, so from where should I download images as these brand logos are pixelated? I'll change the integrations.

@FelixMalfait
Copy link
Member

For the image quality you can export a higher resolution version in Figma
Screenshot 2024-02-07 at 18 41 45

Since you don't have the up-to-date Figma, here they are:

Rectangle 21 (5) Rectangle 21 (4) Rectangle 21 (3) Rectangle 21 (2)

And in even higher resolution in case the one above are not enough (I guess they should be?):
Rectangle 21 (9)
Rectangle 21 (8)
Rectangle 21 (7)
Rectangle 21 (6)

Thanks

@Kanav-Arora
Copy link
Contributor Author

Kanav-Arora commented Feb 7, 2024

For the image quality you can export a higher resolution version in Figma Screenshot 2024-02-07 at 18 41 45

Since you don't have the up-to-date Figma, here they are:

Rectangle 21 (5) Rectangle 21 (4) Rectangle 21 (3) Rectangle 21 (2)
And in even higher resolution in case the one above are not enough (I guess they should be?): Rectangle 21 (9) Rectangle 21 (8) Rectangle 21 (7) Rectangle 21 (6)

Thanks

I tried higher resolution but they are pixelated. I'll check branch resources once on their official website.

@Kanav-Arora
Copy link
Contributor Author

@FelixMalfait
I have changed the text and brand logos. I downloaded logos from brand sites so they are of good quality but I need Twenty high resolution logo. Rest everything is done ig.

@Bonapara
Copy link
Member

Bonapara commented Feb 8, 2024

@Kanav-Arora you may find it here:
https://github.com/twentyhq/twenty/blob/main/packages/twenty-docs/static/img/logo-square-dark.svg

Thanks!

@Kanav-Arora
Copy link
Contributor Author

Hi @FelixMalfait
Done with the changes.

@FelixMalfait
Copy link
Member

Thanks! It's still the big Windmill logo

@Kanav-Arora
Copy link
Contributor Author

@FelixMalfait done

@Kanav-Arora Kanav-Arora changed the title WIP: 3865-Add-Integrations 3865-Add-Integrations Feb 9, 2024
@Kanav-Arora
Copy link
Contributor Author

Hi @FelixMalfait
Does this PR requires any further changes? Can you please review this?

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, good work as always @Kanav-Arora :)

@charlesBochet
Copy link
Member

@Kanav-Arora I'm merging it. As a follow up, could you introduce a featureFlag (similar to IS_MESSAGING_ENABLED) and use it to hide integration link in the Settings navigation?

@FelixMalfait
Copy link
Member

@charlesBochet why would we want to keep it behind a feature flag? Zapier app has been published

@charlesBochet
Copy link
Member

charlesBochet commented Feb 13, 2024

Also as follow up here is a list of small things to adjust:

  • Github logo resolution seems to low
  • the font weight seems different between figma and the implementation
  • the arrow size looks different

Other than that it looks great!

@charlesBochet
Copy link
Member

@Kanav-Arora I have actually added the featureFlag in the last commit so we can merge it!

@charlesBochet charlesBochet merged commit 7b88e5b into twentyhq:main Feb 13, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integrations tab in Settings
4 participants