3804 use email visibility to display only the shared information frontend #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-display-only-the-shared-information-frontend
…e-shared-information-frontend
Weiko
reviewed
Feb 8, 2024
packages/twenty-front/src/modules/activities/emails/components/EmailThreadPreview.tsx
Outdated
Show resolved
Hide resolved
Weiko
reviewed
Feb 8, 2024
| }) => css` | ||
| cursor: ${visibility === 'share_everything' ? 'pointer' : 'default'}; | ||
| `; | ||
|
|
||
| const StyledCardContent = styled(CardContent)` |
There was a problem hiding this comment.
I was more thinking about this pattern
const StyledCardContent = styled(CardContent)<{ visibility: string }>`
align-items: center;
display: flex;
gap: ${({ theme }) => theme.spacing(2)};
height: ${({ theme }) => theme.spacing(12)};
padding: ${({ theme }) => theme.spacing(0, 4)};
cursor: ${({ visibility }) =>
visibility === 'share_everything' ? 'pointer' : 'default'};
`;
You can ignore if it's not used this way in the rest of the repo but it was my assumption
@bosiraphael
Weiko
deleted the
3804-use-email-visibility-to-display-only-the-shared-information-frontend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3804
Enregistrement.de.l.ecran.2024-02-07.a.16.50.12.mov