feat: workspace:health nullable fix #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magrinj
commented
Feb 8, 2024
| @@ -188,16 +188,6 @@ export class RelationMetadataHealthService { | |||
| }); | |||
| } | |||
|
|
|||
| if (relationColumn.isNullable !== relationFieldMetadata.isNullable) { | |||
There was a problem hiding this comment.
Not needed as we're checking nullability on foreign keys in the field check
| import { kebabCase } from 'src/utils/kebab-case'; | ||
|
|
||
| @Injectable() | ||
| export class CommandLogger { |
There was a problem hiding this comment.
Create some command logger logic here that can be shared between commands
| this.logger.log('Running in dry run mode, rolling back transaction'); | ||
|
|
||
| await queryRunner.rollbackTransaction(); | ||
|
|
||
| await this.workspaceLogsService.saveLogs(storage, workspaceMigrations); |
There was a problem hiding this comment.
Move creation of logs file inside command, doesn't feel to be the correct place directly in the services
Weiko
reviewed
Feb 8, 2024
| } | ||
|
|
||
| try { | ||
| await fs.writeFile( |
There was a problem hiding this comment.
Should we use fileUploadService here to write to S3 on prod env?
There was a problem hiding this comment.
@Weiko Already discussed with @charlesBochet, when I've implemented it. As it's only here to write logs of command, we don't want to store this in s3, just locally :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is implementing the
nullablekind in the--fixoption ofworkspace:healthcommand.The core was created here #3863
Fix #3840