Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultAvatarUrl to core user #3883

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Feb 8, 2024

This PR should be deployed before deploying #3737

@martmull martmull marked this pull request as ready for review February 8, 2024 11:47
@martmull martmull linked an issue Feb 8, 2024 that may be closed by this pull request
@@ -34,6 +34,10 @@ export class User {
@Column()
email: string;

@Field({ nullable: true })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I think we should not have this in this PR. It should be added in the other one :)

@charlesBochet charlesBochet merged commit bcc6259 into main Feb 8, 2024
12 of 13 checks passed
@charlesBochet charlesBochet deleted the add-default-avatar-url-to-core-user branch February 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Timebox] Separate user creation from workspace creation
2 participants