feat: health check enum #3913
Merged
feat: health check enum #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magrinj
commented
Feb 12, 2024
| const mainDataSource = this.typeORMService.getMainDataSource(); | ||
|
|
||
| // TODO: remove special case for enum type, should we include this to fieldMetadataTypeToColumnType? |
There was a problem hiding this comment.
Actually fieldMetadataTypeToColumnType is used in other places, so we can't change it.
This special case only happen here
Weiko
approved these changes
Feb 12, 2024
packages/twenty-server/src/workspace/workspace-health/services/field-metadata-health.service.ts
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding some health check on enum types, the goal is to verify that
defaultValueis matching with one of the provided options.