Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3815 blocklist connect frontend #3930

Merged
merged 12 commits into from
Feb 15, 2024
Merged

3815 blocklist connect frontend #3930

merged 12 commits into from
Feb 15, 2024

Conversation

bosiraphael
Copy link
Contributor

@bosiraphael bosiraphael commented Feb 13, 2024 •
edited

Closes #3815

  • Add IS_BLOCKLIST_ENABLED feature flag and remove IS_MESSAGING_ENABLED gate at model creation

There is still work to do:

  • Add validation
  • Prevent user from creating two times the same blocklist item (this will likely be done using a pre-hook)

@Weiko Weiko force-pushed the 3815-blocklist-connect-frontend branch from 95ba4ff to 1b0dd8e Compare February 15, 2024 15:47
Weiko
Weiko approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with and without flag, LGTM

@Weiko Weiko merged commit 0b93a67 into main Feb 15, 2024
14 of 15 checks passed
@Weiko Weiko deleted the 3815-blocklist-connect-frontend branch February 15, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weiko Weiko Weiko approved these changes

Assignees

@bosiraphael bosiraphael

Labels
PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blocklist: Connect frontend
3 participants
@bosiraphael @Weiko @charlesBochet