Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[messaging] Remove ids from enqueued jobs #3936

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Feb 13, 2024

Context

bullmq use those ids as unique identifiers to not enqueue the same job twice. However in this case we were not using unique values so I'm fixing that by removing them. Bull-mq will handle this part and generate ids for us.

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosiraphael bosiraphael merged commit 7f122a4 into main Feb 13, 2024
15 checks passed
@bosiraphael bosiraphael deleted the c--fix-import-message-participant-uppercase branch February 13, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants