-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sync metadata can alter and update a field #3944
Conversation
@@ -55,7 +55,7 @@ export class WorkspaceFieldComparator { | |||
const standardFieldMetadataMap = transformMetadataForComparison( | |||
standardObjectMetadata.fields, | |||
{ | |||
propertiesToIgnore: fieldPropertiesToStringify, | |||
propertiesToStringify: fieldPropertiesToStringify, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOOoooops !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested it, works very well, LGTM!
@@ -55,7 +55,7 @@ export class WorkspaceFieldComparator { | |||
const standardFieldMetadataMap = transformMetadataForComparison( | |||
standardObjectMetadata.fields, | |||
{ | |||
propertiesToIgnore: fieldPropertiesToStringify, | |||
propertiesToStringify: fieldPropertiesToStringify, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha
This PR si fixing a missing part in
workspace:sync-metadata
command, updating a field was not implemented.It also fix an issue that was ignoring some field metadata before comparing them.