Fix missing feature flag on messaging listeners #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
approved these changes
Feb 13, 2024
| @@ -311,6 +311,9 @@ export class WorkspaceQueryRunnerService { | |||
| private removeNestedProperties<Record extends IRecord = IRecord>( | |||
| record: Record, | |||
| ) { | |||
| if (!record) { | |||
| return record; | |||
charlesBochet
approved these changes
Feb 13, 2024
charlesBochet
deleted the
c--fix-feature-flags-not-used-on-messaging-listeners
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Messaging listeners add logic to other objects which means, in our case, updating a person or a workspace member was triggering logic within the messaging module which should only be enabled for workspaces having the IS_MESSAGING_ENABLED featureFlag.