3889 activate settingsaccountsemailsinboxsettings #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout personId and workspaceMemberId
Weiko
reviewed
Feb 14, 2024
...essaging/repositories/create-companies-and-contacts/create-companies-and-contacts.service.ts
Outdated
Show resolved
Hide resolved
...ages/twenty-server/src/workspace/messaging/services/utils/create-queries-from-message-ids.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/workspace/messaging/services/utils/get-domain-name-from-handle.ts
Outdated
Show resolved
Hide resolved
| type: FieldMetadataType.BOOLEAN, | ||
| label: 'Is Contact Auto Creation Enabled', | ||
| description: 'Is Contact Auto Creation Enabled', | ||
| icon: 'IconUserCircle', |
There was a problem hiding this comment.
You can set a defaultValue here FYI (so you don't have to put it in the insert in google-gmail.service.ts
Weiko
reviewed
Feb 14, 2024
| @Injectable() | ||
| export class MessageService { | ||
| constructor( | ||
| private readonly workspaceDataSourceService: WorkspaceDataSourceService, | ||
| private readonly messageChannelMessageAssociationService: MessageChannelMessageAssociationService, | ||
| private readonly messageThreadService: MessageThreadService, | ||
| private readonly messageParticipantService: MessageParticipantService, | ||
| private readonly messageChannelService: MessageChannelService, | ||
| private readonly createCompaniesAndContactsService: CreateCompaniesAndContactsService, |
There was a problem hiding this comment.
Note, can be done in another PR: I prefer to avoid injecting non-repository services inside repository service, you are including business logic here. You can create a logic service that will wrap everything
There was a problem hiding this comment.
I'll do that in another PR
Weiko
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3889