Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[messaging] fix add messageParticipant not in a transaction #3981

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Feb 14, 2024

Context

  • isContactAutoCreationEnabled has been recently added however some workspaces don't have this new column, we need to handle that differently. This PR reverts that change so we can still create new contact even without the boolean.
    Other places shouldn't fail and return null (false) instead.
  • Added a missing instance of transactionManager in the saveParticipants method, because of this, participants were saved before the messages so it was generating an error in DB with FK constraint
Screenshot 2024-02-14 at 19 22 52

Test

tested full import locally

@Weiko Weiko merged commit 49cc01d into main Feb 14, 2024
14 of 15 checks passed
@Weiko Weiko deleted the c--fix-add-message-participant-not-in-transaction branch February 14, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants