Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use backspace for clearing record table cell. #4299

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Use backspace for clearing record table cell. #4299

merged 6 commits into from
Mar 11, 2024

Conversation

lucasbordeau
Copy link
Contributor

@lucasbordeau lucasbordeau commented Mar 4, 2024 •
edited

Closes #3726

@lucasbordeau
Copy link
Contributor Author

@selango1 this issue was a bit hard for a good first issue, I completed it today so we can move forward.

@charlesBochet charlesBochet dismissed thaisguigon’s stale review March 11, 2024 14:07

Changes have been made

@lucasbordeau lucasbordeau merged commit e26572b into main Mar 11, 2024
7 checks passed
@lucasbordeau lucasbordeau deleted the feat/3726-2 branch March 11, 2024 14:19
@github-actions GitHub Actions
Copy link

TODOs/FIXMEs:

  • // TODO: refactor with relationDefiniton once the PR is merged : https://github.com/twentyhq/twenty/pull/4378: packages/twenty-front/src/modules/object-record/utils/generateEmptyFieldValue.ts

Generated by 🚫 dangerJS against 76e5b3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomtrp thomtrp thomtrp approved these changes

@thaisguigon thaisguigon thaisguigon left review comments

@charlesBochet charlesBochet Awaiting requested review from charlesBochet

Assignees

@thaisguigon thaisguigon

Labels
PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear record table cell content when using delete / backspace
4 participants
@lucasbordeau @thaisguigon @thomtrp @charlesBochet