Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event rows to Show Page Calendar tab #4319

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

thaisguigon
Copy link
Contributor

Closes #4287

@thaisguigon thaisguigon marked this pull request as ready for review March 5, 2024 15:42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We changed the type: startDate and endDate are now startsAt and endsAt, status has been replaced by a boolean isCanceled and visibility is 'METADATA' | 'SHARE_EVERYTHING'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I made the corresponding changes! I also pushed a commit that improves calendar events, months and days sorting.

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a comment about the changes in the data model

@bosiraphael
Copy link
Contributor

LGTM

@bosiraphael bosiraphael merged commit dd96120 into main Mar 7, 2024
16 checks passed
@bosiraphael bosiraphael deleted the feat/add-event-rows branch March 7, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Page/Activities Panel/Calendar Tab - Add event rows
2 participants