Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Only show 2 relations in ActivityTargetChips #4325

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Chore: Only show 2 relations in ActivityTargetChips #4325

merged 2 commits into from
Mar 7, 2024

Conversation

Abhi3685
Copy link
Contributor

@Abhi3685 Abhi3685 commented Mar 5, 2024

Refs #4235

Twenty.PR.Recording.mp4

@thomtrp thomtrp force-pushed the chore/limit-activity-target-relations-count branch from 80d9cc4 to f7cec2c Compare March 7, 2024 10:50
@thomtrp thomtrp force-pushed the chore/limit-activity-target-relations-count branch from f7cec2c to 84bd12d Compare March 7, 2024 10:51
thomtrp
thomtrp approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@thomtrp thomtrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Abhi3685, thank you so much for your contribution.

I just removed the dynamic width calculation logic since it adds complexity while the default behavior is acceptable.

Great work 🔥

@thomtrp thomtrp merged commit e8252ec into twentyhq:main Mar 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomtrp thomtrp thomtrp approved these changes

Assignees

@thomtrp thomtrp

Labels
PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Abhi3685 @thomtrp @charlesBochet @abindra202955