Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextInput height fix #4327

Merged
merged 1 commit into from
Mar 7, 2024
Merged

TextInput height fix #4327

merged 1 commit into from
Mar 7, 2024

Conversation

jrachelr
Copy link
Contributor

@jrachelr jrachelr commented Mar 5, 2024 •
edited

Before:
Screenshot 2024-03-05 at 12 05 02 pm
Screenshot 2024-03-05 at 12 05 50 pm

After:

  • Changed TextInput component to 32px:
Screenshot 2024-03-05 at 11 58 40 am - Changed box-sizing to `box-sizing: border-box` to prevent overflow and for consistency with button elements Screenshot 2024-03-05 at 12 02 36 pm

@jrachelr jrachelr marked this pull request as draft March 5, 2024 20:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against 456be80

@jrachelr jrachelr marked this pull request as ready for review March 5, 2024 20:06
@charlesBochet
Copy link
Member

charlesBochet commented Mar 5, 2024 •
edited

Hi @jrachelr, which issue is this PR referring too? :)

@charlesBochet charlesBochet self-assigned this Mar 6, 2024
@charlesBochet
Copy link
Member

Found it :) #4201

charlesBochet
charlesBochet approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jrachelr :)

@charlesBochet charlesBochet merged commit eabece6 into twentyhq:main Mar 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees

@charlesBochet charlesBochet

Labels
PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrachelr @charlesBochet