Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40 remove self billing feature flag #4379

Merged
merged 14 commits into from
Mar 12, 2024

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Mar 8, 2024

No description provided.

@martmull martmull force-pushed the 40-remove-elf-billing-feature-flag branch from 91e1114 to 827c0e7 Compare March 8, 2024 18:16
@martmull martmull marked this pull request as ready for review March 10, 2024 18:54
@martmull martmull force-pushed the 40-remove-elf-billing-feature-flag branch from d50fdb0 to 8fc4dcb Compare March 11, 2024 09:07
@magrinj magrinj changed the title 40 remove elf billing feature flag 40 remove self billing feature flag Mar 12, 2024
Copy link
Member

@magrinj magrinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small question, but it sounds good to me !

@@ -27,7 +32,7 @@ export class BillingSubscription {
@UpdateDateColumn({ type: 'timestamp with time zone' })
updatedAt: Date;

@OneToOne(() => Workspace, (workspace) => workspace.billingSubscription, {
@ManyToOne(() => Workspace, (workspace) => workspace.billingSubscriptions, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martmull A workspace can have many billing subscription ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, canceled ones

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@charlesBochet charlesBochet merged commit 62d414e into main Mar 12, 2024
16 checks passed
@charlesBochet charlesBochet deleted the 40-remove-elf-billing-feature-flag branch March 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants