Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing to open options for an opportunity on company record. #4387

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Allowing to open options for an opportunity on company record. #4387

merged 2 commits into from
Mar 11, 2024

Conversation

Aayush-23
Copy link
Contributor

fixes #4344

Removed the check isOpportunityCompanyRelation to show options for an opportunity.

Screenshot 2024-03-09 at 11 47 56 AM

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024 •
edited

TODOs/FIXMEs:

  • /* TODO: temporary to prevent removing a company from an opportunity */}: packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx

Generated by 🚫 dangerJS against 4416b46

@thomtrp thomtrp self-assigned this Mar 11, 2024
thomtrp
thomtrp approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@thomtrp thomtrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Aayush-23!

@thomtrp thomtrp merged commit 5cf4047 into twentyhq:main Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomtrp thomtrp thomtrp approved these changes

Assignees

@thomtrp thomtrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I cannot detach an Opportunity from a Company
2 participants
@Aayush-23 @thomtrp