fix serverurl in openapi docs for self hosted instance #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs/FIXMEs:
|
magrinj
reviewed
Mar 12, 2024
Comment on lines
39
to
41
| const baseUrl = | ||
| this.environmentService.getServerUrl() || | ||
| `${request.protocol}://${request.get('host')}`; |
There was a problem hiding this comment.
@brendanlaschke To avoid declaration of this 2 times, we can create a private function that compute the baseUrl
There was a problem hiding this comment.
can we also remove the trailing slash in case it's present, tested this morning and:
SERVER_URL=https://api.twenty.com works
SERVER_URL=https://api.twenty.com/ does not
…ed openapi path hardcoded api.twenty.com
|
should be fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4070