Build arg setter for position #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
commented
Mar 11, 2024
| import { FieldMetadataType } from 'src/metadata/field-metadata/field-metadata.entity'; | ||
|
|
||
| @Injectable() | ||
| export class ArgsSettersFactory { |
There was a problem hiding this comment.
Not a big fan of the name since it does not "set" existing args but rather build new ones. But I don't know how I should call it.
There was a problem hiding this comment.
I agree, maybe we can just call it ArgFactory for now ?
cc @charlesBochet
There was a problem hiding this comment.
renamed QueryRunnerArgFactory so we avoid mistakes between existing arg factories in the builder
magrinj
reviewed
Mar 11, 2024
| import { FieldMetadataType } from 'src/metadata/field-metadata/field-metadata.entity'; | ||
|
|
||
| @Injectable() | ||
| export class ArgsSettersFactory { |
There was a problem hiding this comment.
I agree, maybe we can just call it ArgFactory for now ?
cc @charlesBochet
packages/twenty-server/src/workspace/workspace-query-runner/factories/arg-setters.factory.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/workspace/workspace-query-runner/factories/arg-setters.factory.ts
Outdated
Show resolved
Hide resolved
| return this.applySettersToArgsRecursive(args, options, fieldMetadataMap); | ||
| } | ||
|
|
||
| private async applySettersToArgsRecursive( |
There was a problem hiding this comment.
Not sure of the naming too, maybe computeArgs ?
There was a problem hiding this comment.
renamed createArgsRecursive
thomtrp
force-pushed
the
tt-build-position-setter
branch
from
edf2f36
to
983c72c
Compare
added 2 commits
March 11, 2024 14:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Position input needs to be of type :
number | first | last:number, returns valuefirst, fetch first element ascending and setposition / 2last, fetch first element descending and setposition + 1This logic is integrated into a new factory call arg-setters. It iterates recursively on all arguments and override existing ones using setter function.