Build listener to backfill position #4432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
commented
Mar 12, 2024
| private readonly recordPositionQueryFactory: RecordPositionQueryFactory, | ||
| ) {} | ||
|
|
||
| async create( |
There was a problem hiding this comment.
I simply moved the logic of buildPositionValue in there
thomtrp
commented
Mar 12, 2024
| providers: [ | ||
| WorkspaceQueryRunnerService, | ||
| ...workspaceQueryRunnerFactories, | ||
| RecordPositionListener, |
There was a problem hiding this comment.
@charlesBochet @magrinj I don't know if the service / job / factory / listener should live into the query runner folder. Is there a better place ?
Weiko
reviewed
Mar 12, 2024
| recordId?: string, | ||
| ): Promise<string> { | ||
| const name = | ||
| (objectMetadata.isCustom ? '_' : '') + objectMetadata.nameSingular; |
There was a problem hiding this comment.
nit: We should probably have a helper for that for when we will remove this logic
| dataSourceSchema: string, | ||
| recordId: string, | ||
| ): Promise<string> { | ||
| return `UPDATE ${dataSourceSchema}."${name}" |
There was a problem hiding this comment.
prepared statements would be safer
...ages/twenty-server/src/workspace/workspace-query-runner/jobs/record-position-backfill.job.ts
Show resolved
Hide resolved
packages/twenty-server/src/integrations/event-emitter/types/object-record-create.event.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the position set for all our records.
Currently, this is still possible to create records without a position through the rest API.
This PR:
I re-used the existing logic that overrides the position in the args during a normal creation through web. I put it in a new factory
RecordPositionFactory.TODO: