fix: record object chip background color when idle (not hovered)

[emadbaqeri]

Fixes #4651

Screen.Recording.2024-03-26.at.15.08.16.mov

[github-actions]

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against ecbb695

[FelixMalfait]

Thanks @emadbaqeri

I think the issue only referred to StyledBoardCardHeader only (check RecordBoardCard.tsx and probably change it there). You'll have to add this variant to the recordChip as I see it's only available at the entityChip level now

cc @Bonapara

[emadbaqeri]

StyledBoardCardHeader

I not sure I understand this so I'm asking a dummy question, you mean I should do something like this?

export type RecordChipProps = {
  ...,
  variant?: EntityChipVariant;
};


<RecordChip variant={EntityChipVariant.Transparent} />

And this way we can control the RecordChip variant property from outside and this should be better I think as you mentioned.

[FelixMalfait]

Yes that's how I would have done it too! That way we can follow the design that's on the issue

[emadbaqeri]

Yes that's how I would have done it too! That way we can follow the design that's on the issue

I've updated the RecordChip component to get a variant prop as you said, now ready to merge :)

[bosiraphael]

LGTM, thank you for contributing @emadbaqeri :)

[FelixMalfait]

You should pass the variant in StyledBoardCardHeader, not change the default variant for all RecordChips :)
(look at the design on the issue, it's only the header of the card)

[ijreilly]

@FelixMalfait is it ok for you now?

changes implemented