Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isAuditLogged column to object-metadata-entity #4898

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

Jeetch8
Copy link
Contributor

@Jeetch8 Jeetch8 commented Apr 9, 2024

Added isAuditLogged column to object-metadata-entity.ts

This is my first open source pull request. Please do let me know if made any mistake. I will be greatfull. Thank u

Copy link

github-actions bot commented Apr 9, 2024

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against 989951f

@charlesBochet
Copy link
Member

Hi @Jeetch8, thanks for your PR. What is the motivation behind this change?
@FelixMalfait FYI

@Jeetch8
Copy link
Contributor Author

Jeetch8 commented Apr 11, 2024

i was trying to resolve the issue #4890

@charlesBochet
Copy link
Member

Ok! So I think you also need to modify: EntityEventsToDbListener :)

@Jeetch8
Copy link
Contributor Author

Jeetch8 commented Apr 12, 2024

Hii, please check the additions.

…runner/listeners/entity-events-to-db.listener.ts
@FelixMalfait
Copy link
Member

Thanks! You also need to create the migration by running yarn nx typeorm twenty-server -- migration:generate src/database/typeorm/metadata/migrations/addIsAuditLogged -d src/database/typeorm/metadata/metadata.datasource.ts
I will do it for you

@FelixMalfait FelixMalfait merged commit 280229b into twentyhq:main Apr 12, 2024
3 checks passed
@amitshuklabag
Copy link

It still arises today In the docker image, so please fix it in the docker image.

it was arising when I login The login was completed but showed a blank screen and in the network tab API failed with the message

extensions:{code: "INTERNAL_SERVER_ERROR", response: "column ObjectMetadataEntity.isAuditLogged does not exist"} code: "INTERNAL_SERVER_ERROR" response:"column ObjectMetadataEntity.isAuditLogged does not exist" message:"QueryFailedError"

I tried to run migration command as well but same issue yarn nx typeorm twenty-server -- migration:generate src/database/typeorm/metadata/migrations/addIsAuditLogged -d src/database/typeorm/metadata/metadata.datasource.ts

@amitshuklabag
Copy link

amitshuklabag commented Apr 29, 2024

@FelixMalfait In your new release Now I can log in but have some other issues please check it https://hub.docker.com/layers/twentycrm/twenty/main/images/sha256-51833ef825d15dc7e8c5d64fb2d1c7f8679b31bbc9a783f3d6eb18df7d29e7d5?context=explore multiple API are failed like these Error during useFindManyRecords for "workspaceMembers", Internal Server Error

@FelixMalfait
Copy link
Member

Hey @amitshuklabag - the "main" docker image is used for development and is not meant to be deployed. You should use the latest tagged release instead

@amitshuklabag
Copy link

amitshuklabag commented Apr 29, 2024

@FelixMalfait The Latest also has had issues over the last 3 days, I checked it.

When we deploy fresh setup and click on login it shows on the web page

Server’s on a coffee break Cannot read properties of undefined (reading 'length')

@FelixMalfait
Copy link
Member

Arf sorry. It will be fixed in the next release 0.11 for sure, we do extensive checks every 2 weeks when we release new feature

@amitshuklabag
Copy link

amitshuklabag commented Apr 30, 2024

Thanks for updating the latest tag on docker, now the server is on coffee break, issue is resolved.

But still, it has issues related to listing the companies, tasks, and activities in the docker latest tag.

I see in the console, the companies page failed with the error in the API "GraphQL errors on workspaceMember: {\"message\":\"Unknown field 'integrationType' on type 'company'\"}"

Multiple operations API failed with the same like FindManyActivities, FindOneWorkspaceMember, and FindManyActivityTargets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants