Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate imports by VSCode #4959

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Fix duplicate imports by VSCode #4959

merged 1 commit into from
Apr 14, 2024

Conversation

FelixMalfait
Copy link
Member

Fixes #3819
This was annoying.
It was caused by a duplicate rule in VS Code config.

"[javascript][typescript][typescriptreact]": {
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit",
"source.addMissingImports": "always"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source.addMissingImports was already set in previous typescriptreact array.
Removing it here solves the issue and imports still work

@FelixMalfait
Copy link
Member Author

@charlesBochet fyi merging

@FelixMalfait FelixMalfait merged commit f82b1ff into main Apr 14, 2024
3 checks passed
@FelixMalfait FelixMalfait deleted the fix-3819 branch April 14, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Timebox] Fix double imports on save from VSCode
1 participant